JSONs for old units IMPLEMENTED

[COOLguy]

Anyone who would like bonus points from me and Daniel -

Would someone please do the jsons for the old knight and pikemen units? We need them in json format so that we can fix the bonus bugs for the new units. Message me if you have questions or need help!

[Endru1241]

I didn't want to start new topic.
I am right that this units still doesn't have it's jsons?
worker
wagon
healer
ornithopter
assassin
scout bird
transport
galley (warship)
trireme (fireship)
spartan hoplite
tie fighter
missionary
catapult ship
money courier
axe thrower
great transport
roman legionary

And this ones lack stat sheet in jsons:
catapult
wall
outpost
heavy catapult
gate
tanegashima ashigaru
galleas(adv_warship)
canoneer
priest
cannon tower
centurion
cannon ship
?

[Stratego (dev)]

mostly!

if u are about to help jsoning them i can send u the whole code and json base we have so u can work on it - would be awesome!

daniel

[Endru1241]

Sure. I can try for how many files my patience will stand.
But I would have few questions, which could be then added to https://www.androidutils.com/forum/view ... ed332b04ba
1. Complete list of used unit categories (if you have one) and if it is only text based or coded (is adding new category possible without code change)
2. Is there any relation between categories (like class inheritance) and what kind? (For example if U_ARCHERS_FOOT is treated as U_ARCHERS)
3. Do damage modifiers only choose highest bonus or sum up if targeted unit is placed with few categories which attacker have bonuses against?
4. Which effects need to be placed in trnModifiers to affect unit - is it only those which doesn't have jsons?

[Stratego (dev)]

email me please and i send u everything. thanks!

answers_
1. Complete list of used unit categories - always changes, i send u current
2. Is there any relation between categories yes, there is ancapsulation, you will see
3. Do damage modifiers only choose highest bonus or sum up if targeted unit is placed with few categories which attacker have bonuses against? - i think the last value will be calsulated (last int he order of bonus lines)
4. Which effects need to be placed in trnModifiers to affect unit - on jsoning you need to put there the same as were in the in code version.

[Endru1241]

Made jsons for first non-combat units. I anyone can see any mistakes - please tell.
I probably will be posting here next ones.

[Endru1241]

New and complemented jsons + money courier correction.

[Stratego (dev)]

Please someone help us checking the json settings!
Endru makes the jsons
i myself will check the format and implement,
but we need someone checking the values to be sure not changing any unit accidentally - thanks!

[Endru1241]

And here are next 3 jsons.

[Endru1241]

Centurion correction

[Stratego (dev)]

i have started checking the first as i see no one has time to help now.
in wagon i see:
1. convertresistance is a float value you put 100 instead of 1 or 1.0
2. there is no such category as U_MOUNTED_KNIGTS instead always chhose category name from category list this one is good: U_MOUNTED_KNIGTHS (the in-code categories are not category names only "listnames" that was assigned to categories in consts json - but more or less they are names similarly but not always). On the other hand U_SHIP_ATTACK was a lucky same naming on both places. so all category names should be checked in consts_in_game file
2. unit type instead if category reference on builders:
wrong:

Code: Select all

    "trnBuilders": {
        "unitTypes": [
          "U_WORKERS",
          "UNIT_TC"
        ]
      },

correct:

Code: Select all

      "trnBuilders": {
         "categories": [
          "U_WORKERS"
        ],
        "unitTypes": [
          "UNIT_TC"
        ]
      },

Other than these it looks good! thanks! it is in!

Endru: can u check the ready jsons based on the findings i wrote here?

[Endru1241]

Yeah, Ill check.

[Stratego (dev)]

ok! tell me if i can check the nextone - thanks!

also came to me that it would be easier if u set up modding on your device so you will be able to check your json in work - would u try?

[Endru1241]

I can try.

These are corrected ones (actually not sure if all of them were changed). Could You look at centurion trnEffectAffectTurnsLeft and cannoneer bonuses consolidation.

Gonna delete older files to avoid confusion.

[Endru1241]

Plus new ones.

[Stratego (dev)]

also came to me that it would be easier if u set up modding on your device so you will be able to check your json in work - would u try?

[Endru1241]

I can try.

So how to start?

[Endru1241]

few corrections:

[Stratego (dev)]

all of these are in ! thanks!