Belfry - unit json 2(implementing a new unit) PASSED

Here i will list the apprentices and their learning tasks, so others also can follow how it goes.
Please DONT POST HERE any solutions on the given task earlier than the apprentice, you can ask questions from him tough.
Post Reply
Stratego (dev)
Site Admin
Posts: 15741
Joined: Fri Apr 25, 2014 9:28 pm

Belfry - unit json 2(implementing a new unit) PASSED

Post by Stratego (dev) »

Your next mission is the same as were for Samuel: "Samuel - unit json 2(implementing a new unit)"
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

Should I just look at his post?
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Stratego (dev)
Site Admin
Posts: 15741
Joined: Fri Apr 25, 2014 9:28 pm

Re: Belfry - unit json 2(implementing a new unit)

Post by Stratego (dev) »

yes
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

Okay sorry for putting the file on Sam's topic. Here it is.
Attachments
bld_jp_concrete_artillery.json
(4.02 KiB) Downloaded 141 times
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

Stratego (dev) wrote: Mon Jun 18, 2018 10:47 pm Your next mission is the same as were for Samuel: "Samuel - unit json 2(implementing a new unit)"
Is this good?
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Stratego (dev)
Site Admin
Posts: 15741
Joined: Fri Apr 25, 2014 9:28 pm

Re: Belfry - unit json 2(implementing a new unit)

Post by Stratego (dev) »

seems good but you missed things

this was the task:
- name the image properly
- make a json for it (start from a similar)
- make sure it is a mapeditor unit only


deliverables
- unit json (with new ID, next jJP id can be used: 707)
- image with nice name, and working "team coloring"
- image texting "name" and "flavour text"
- order in the buildlist json (indicating where to put this in list)
you still need these to finish:
- unit json (with new ID, next jJP id can be used: 707)
- image with nice name, and working "team coloring"
- image texting "name" and "flavour text"
- order in the buildlist json (indicating where to put this in list)[/quote]
- EXTRA: since then we have 2 images and 2 stages: occupied and unoccupied, if you can make it that is extra good! - no problem if not.
- EXTRA2: you need this sound definition too: {"soundEvent":"UNIT_ATTACK","packName":"SOUND_PACK_UNIT_ATTACK_TANK_SHOOT"},
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

Should I replace "JP" with 707?
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
User avatar
godOfKings
Posts: 3302
Joined: Fri Sep 22, 2017 4:50 pm

Re: Belfry - unit json 2(implementing a new unit)

Post by godOfKings »

no, change unit type from 331 to 707
There is no place for false kings here, only those who proves themselves to b the true kings of legend, or serves under me

For I watch over this world looking for those worthy to become kings, and on the way get rid of the fakes and rule over the fools
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

godOfKings wrote: Sat Aug 11, 2018 7:40 am no, change unit type from 331 to 707
Thanks for the help mate!
Attachments
bld_jJP_concrete_artillery.png
bld_jJP_concrete_artillery.png (2.39 KiB) Viewed 7543 times
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

Here is the Json the post was working up.
Attachments
bld_jp_concrete_artillery.json
(4.1 KiB) Downloaded 129 times
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Stratego (dev)
Site Admin
Posts: 15741
Joined: Fri Apr 25, 2014 9:28 pm

Re: Belfry - unit json 2(implementing a new unit)

Post by Stratego (dev) »

nice!

but you missed things:

Pu55intheBoots gave JP fixed artillery image so here the tasks
- name the image properly
- make a json for it (start from a similar)
- make sure it is a mapeditor unit only


deliverables
- unit json (with new ID, next jJP id can be used: 707)
- image with nice name, and working "team coloring"
- image texting "name" and "flavour text"
- order in the buildlist json (indicating where to put this in list)
- EXTRA: since then we have 2 images and 2 stages: occupied and unoccupied, if you can make it that is extra good! - no problem if not.
- EXTRA2: you need this sound definition too: {"soundEvent":"UNIT_ATTACK","packName":"SOUND_PACK_UNIT_ATTACK_TANK_SHOOT"},


when you are please reply me to all bullets, so you and me can be sure you have not missed anything. thanks!
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

Stratego (dev) wrote: Sun Aug 19, 2018 5:57 am nice!

but you missed things:

Pu55intheBoots gave JP fixed artillery image so here the tasks
- name the image properly
- make a json for it (start from a similar)
- make sure it is a mapeditor unit only


deliverables
- unit json (with new ID, next jJP id can be used: 707)
- image with nice name, and working "team coloring"
- image texting "name" and "flavour text"
- order in the buildlist json (indicating where to put this in list)
- EXTRA: since then we have 2 images and 2 stages: occupied and unoccupied, if you can make it that is extra good! - no problem if not.
- EXTRA2: you need this sound definition too: {"soundEvent":"UNIT_ATTACK","packName":"SOUND_PACK_UNIT_ATTACK_TANK_SHOOT"},


when you are please reply me to all bullets, so you and me can be sure you have not missed anything. thanks!
Okay... I don't know how to:

- image with nice name, and working "team coloring"
- image texting "name" and "flavour text"
- order in the buildlist json (indicating where to put this in list)
- make sure it is a mapeditor unit only

If you know please tell me!
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

Here are the images.
Attachments
unit_jp_concrete_artillery_un_ocupied.png
unit_jp_concrete_artillery_un_ocupied.png (2.71 KiB) Viewed 7464 times
unit_jp_concrete_artillery.png
unit_jp_concrete_artillery.png (2.32 KiB) Viewed 7464 times
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

Here is the strings

<string name="UNIT_JP_BLD_CONCRETE_ARTILLERY">JP Concrete Artillery</string>
<string name="UNIT_TXT_JP_BLD_CONCRETE_ARTILLERY">Concrete artillery are very tough units that deliver moderate fire power.</string>
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Stratego (dev)
Site Admin
Posts: 15741
Joined: Fri Apr 25, 2014 9:28 pm

Re: Belfry - unit json 2(implementing a new unit)

Post by Stratego (dev) »

seems good! tell me if all taska are fulfilled and i will check! thanks!
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

Thanks to Pussinboots I was able to complete this. I don't have the buildlist, but every thing else is good. I need help to find the strings for future projects. By the way please check.
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

You still there Stratego?
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Stratego (dev)
Site Admin
Posts: 15741
Joined: Fri Apr 25, 2014 9:28 pm

Re: Belfry - unit json 2(implementing a new unit)

Post by Stratego (dev) »

cool, please send me everything in one email so i can put in - thanks!
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

I sent them to you. How are they?
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Stratego (dev)
Site Admin
Posts: 15741
Joined: Fri Apr 25, 2014 9:28 pm

Re: Belfry - unit json 2(implementing a new unit)

Post by Stratego (dev) »

problems i've found
- unt typename was wrong not JAP but JP (as in the texting)
- there is no sich race as JP, where have u seen it?
- you set it to "needOccupacyDisplay" = false, that is needed to be true
- there was no occupied image defined in json.
- there was missing comma in the sound section - have u checked with json validator?
- you gave there builders however it should not to be able to build
- also in buildlist was in wrong place among the buildables, however it should be in the non-buildables section

see fixed files attached, and compare it to yours to see the differences.
Attachments
buildlists.json
(23.3 KiB) Downloaded 119 times
bld_jp_concrete_artillery.json
(4.42 KiB) Downloaded 121 times
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

Here they are, I have fixed them.

<string name="UNIT_JAP_BLD_CONCRETE_ARTILLERY">JAP Concrete Artillery</string>
<string name="UNIT_TXT_JAP_BLD_CONCRETE_ARTILLERY">Concrete artillery are very tough units that deliver moderate fire power.</string>

I didn't put JAP because it is a derogatory term here in the U.S. But I don't think it will be a problem because we are not using it in a offensive way.
Attachments
bld_jp_concrete_artillery.json
(4.61 KiB) Downloaded 107 times
unit_jp_concrete_artillery_un_ocupied.png
unit_jp_concrete_artillery_un_ocupied.png (2.71 KiB) Viewed 7357 times
unit_jp_concrete_artillery.png
unit_jp_concrete_artillery.png (2.32 KiB) Viewed 7357 times
bld_jp_concrete_artillery.json
(4.61 KiB) Downloaded 117 times
buildlists.json
(23.01 KiB) Downloaded 107 times
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Stratego (dev)
Site Admin
Posts: 15741
Joined: Fri Apr 25, 2014 9:28 pm

Re: Belfry - unit json 2(implementing a new unit)

Post by Stratego (dev) »

json: your json is wrong again in some bullets i wrote u, btw i have posted the fixed one, please COMPARE to yours so you will see
(now you even set this unit to be a technology..)

JAP, JP: i have used JP, not JAP
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

Okay I have sent the JSON VIA email.
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

Is this done? @Stratego (dev)
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Stratego (dev)
Site Admin
Posts: 15741
Joined: Fri Apr 25, 2014 9:28 pm

Re: Belfry - unit json 2(implementing a new unit)

Post by Stratego (dev) »

sorry, i dont remember, please resend the email so i can see what was my answer. thanks!
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit)

Post by Belfry777 »

Hi! Here the Jsons should be complete. I have checked both with the validator.

<string name="UNIT_JP_BLD_CONCRETE_ARTILLERY">JP Concrete Artillery</string>
<string name="UNIT_TXT_JP_BLD_CONCRETE_ARTILLERY">Concrete artillery are very tough units that deliver moderate fire power.</string>
Attachments
bld_jp_concrete_artillery.json
(4.5 KiB) Downloaded 90 times
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Stratego (dev)
Site Admin
Posts: 15741
Joined: Fri Apr 25, 2014 9:28 pm

Re: Belfry - unit json 2(implementing a new unit) PASSED

Post by Stratego (dev) »

:)

at first glance seems good :)
User avatar
Puss_in_Boots
Posts: 3209
Joined: Fri Apr 21, 2017 1:23 am
Location: New Jersey

Re: Belfry - unit json 2(implementing a new unit) PASSED

Post by Puss_in_Boots »

Great job! :)
OLÉ
Belfry777
Posts: 1681
Joined: Tue Oct 17, 2017 2:34 am

Re: Belfry - unit json 2(implementing a new unit) PASSED

Post by Belfry777 »

Thanks for all your help boots! Now we can move to another job!
A thousand may fall at your side,
And ten thousand at your right hand;
But it shall not come near you.
Only with your eyes shall you look,
And see the reward of the wicked.
Post Reply

Return to “Under the Hood studies”