JSONs for old units

You can see here listed all Developer problems in which he asks for help regarding AOS from forum users.
Post Reply
User avatar
COOLguy
Posts: 4005
Joined: Sat Jul 12, 2014 2:58 am
Location: Nenuial, Arnor

JSONs for old units

Post by COOLguy » Fri Mar 30, 2018 8:32 pm

Anyone who would like bonus points from me and Daniel -

Would someone please do the jsons for the old knight and pikemen units? We need them in json format so that we can fix the bonus bugs for the new units. Message me if you have questions or need help!
Thanks!
Josh

User avatar
Endru1241
Posts: 304
Joined: Fri Sep 11, 2015 8:43 am
Location: Poland

Re: JSONs for old units

Post by Endru1241 » Sat Aug 31, 2019 9:01 pm

I didn't want to start new topic.
I am right that this units still doesn't have it's jsons?
worker
wagon
healer
ornithopter
assassin
scout bird
transport
galley (warship)
trireme (fireship)
spartan hoplite
tie fighter
missionary
catapult ship
money courier
axe thrower
great transport
roman legionary

And this ones lack stat sheet in jsons:
catapult
wall
outpost
heavy catapult
gate
tanegashima ashigaru
galleas(adv_warship)
canoneer
priest
cannon tower
centurion
cannon ship
?

Stratego (dev)
Site Admin
Posts: 9402
Joined: Fri Apr 25, 2014 9:28 pm

Re: JSONs for old units

Post by Stratego (dev) » Sat Aug 31, 2019 9:07 pm

mostly!

if u are about to help jsoning them i can send u the whole code and json base we have so u can work on it - would be awesome!

daniel

User avatar
Endru1241
Posts: 304
Joined: Fri Sep 11, 2015 8:43 am
Location: Poland

Re: JSONs for old units

Post by Endru1241 » Sat Aug 31, 2019 9:40 pm

Sure. I can try for how many files my patience will stand.
But I would have few questions, which could be then added to https://www.androidutils.com/forum/view ... ed332b04ba
1. Complete list of used unit categories (if you have one) and if it is only text based or coded (is adding new category possible without code change)
2. Is there any relation between categories (like class inheritance) and what kind? (For example if U_ARCHERS_FOOT is treated as U_ARCHERS)
3. Do damage modifiers only choose highest bonus or sum up if targeted unit is placed with few categories which attacker have bonuses against?
4. Which effects need to be placed in trnModifiers to affect unit - is it only those which doesn't have jsons?

Stratego (dev)
Site Admin
Posts: 9402
Joined: Fri Apr 25, 2014 9:28 pm

Re: JSONs for old units

Post by Stratego (dev) » Sun Sep 01, 2019 6:33 am

email me please and i send u everything. thanks!

answers_
1. Complete list of used unit categories - always changes, i send u current
2. Is there any relation between categories yes, there is ancapsulation, you will see
3. Do damage modifiers only choose highest bonus or sum up if targeted unit is placed with few categories which attacker have bonuses against? - i think the last value will be calsulated (last int he order of bonus lines)
4. Which effects need to be placed in trnModifiers to affect unit - on jsoning you need to put there the same as were in the in code version.

User avatar
Endru1241
Posts: 304
Joined: Fri Sep 11, 2015 8:43 am
Location: Poland

Re: JSONs for old units

Post by Endru1241 » Sun Sep 01, 2019 10:20 pm

Made jsons for first non-combat units. I anyone can see any mistakes - please tell.
I probably will be posting here next ones.
Attachments
unit_wagon.json
(4.92 KiB) Downloaded 6 times
unit_moneyman.json
(3.37 KiB) Downloaded 3 times
unit_worker.json
(3.45 KiB) Downloaded 4 times

User avatar
Endru1241
Posts: 304
Joined: Fri Sep 11, 2015 8:43 am
Location: Poland

Re: JSONs for old units

Post by Endru1241 » Mon Sep 02, 2019 10:28 pm

New and complemented jsons + money courier correction.
Attachments
unit_roman_legionare.json
(3.61 KiB) Downloaded 2 times
unit_moneyman.json
(3.34 KiB) Downloaded 3 times
unit_hoplite.json
(3.46 KiB) Downloaded 4 times
unit_centurion.json
(3.25 KiB) Downloaded 4 times
unit_axe_thrower.json
(3.42 KiB) Downloaded 1 time
unit_assasin.json
(3.22 KiB) Downloaded 3 times

Stratego (dev)
Site Admin
Posts: 9402
Joined: Fri Apr 25, 2014 9:28 pm

Re: JSONs for old units

Post by Stratego (dev) » Tue Sep 03, 2019 4:11 am

Please someone help us checking the json settings!
Endru makes the jsons
i myself will check the format and implement,
but we need someone checking the values to be sure not changing any unit accidentally - thanks!

User avatar
Endru1241
Posts: 304
Joined: Fri Sep 11, 2015 8:43 am
Location: Poland

Re: JSONs for old units

Post by Endru1241 » Tue Sep 03, 2019 2:48 pm

And here are next 3 jsons.
Attachments
unit_heavy_catapult.json
(4.91 KiB) Downloaded 1 time
unit_catapult.json
(4.89 KiB) Not downloaded yet
unit_cannoneer.json
(4.27 KiB) Downloaded 2 times

User avatar
Endru1241
Posts: 304
Joined: Fri Sep 11, 2015 8:43 am
Location: Poland

Re: JSONs for old units

Post by Endru1241 » Tue Sep 03, 2019 4:38 pm

Centurion correction
Attachments
unit_centurion.json
(3.35 KiB) Downloaded 2 times

Stratego (dev)
Site Admin
Posts: 9402
Joined: Fri Apr 25, 2014 9:28 pm

Re: JSONs for old units

Post by Stratego (dev) » Tue Sep 03, 2019 6:46 pm

i have started checking the first as i see no one has time to help now.
in wagon i see:
1. convertresistance is a float value you put 100 instead of 1 or 1.0
2. there is no such category as U_MOUNTED_KNIGTS instead always chhose category name from category list this one is good: U_MOUNTED_KNIGTHS (the in-code categories are not category names only "listnames" that was assigned to categories in consts json - but more or less they are names similarly but not always). On the other hand U_SHIP_ATTACK was a lucky same naming on both places. so all category names should be checked in consts_in_game file
2. unit type instead if category reference on builders:
wrong:

Code: Select all

    "trnBuilders": {
        "unitTypes": [
          "U_WORKERS",
          "UNIT_TC"
        ]
      },
correct:

Code: Select all

      "trnBuilders": {
         "categories": [
          "U_WORKERS"
        ],
        "unitTypes": [
          "UNIT_TC"
        ]
      },

Other than these it looks good! thanks! it is in!

Endru: can u check the ready jsons based on the findings i wrote here?

User avatar
Endru1241
Posts: 304
Joined: Fri Sep 11, 2015 8:43 am
Location: Poland

Re: JSONs for old units

Post by Endru1241 » Tue Sep 03, 2019 7:17 pm

Yeah, Ill check.

Stratego (dev)
Site Admin
Posts: 9402
Joined: Fri Apr 25, 2014 9:28 pm

Re: JSONs for old units

Post by Stratego (dev) » Tue Sep 03, 2019 7:30 pm

ok! tell me if i can check the nextone - thanks!

also came to me that it would be easier if u set up modding on your device so you will be able to check your json in work - would u try?

User avatar
Endru1241
Posts: 304
Joined: Fri Sep 11, 2015 8:43 am
Location: Poland

Re: JSONs for old units

Post by Endru1241 » Tue Sep 03, 2019 8:23 pm

I can try.

These are corrected ones (actually not sure if all of them were changed). Could You look at centurion trnEffectAffectTurnsLeft and cannoneer bonuses consolidation.

Gonna delete older files to avoid confusion.
Attachments
unit_wagon.json
(4.92 KiB) Downloaded 2 times
unit_cannoneer.json
(4.21 KiB) Downloaded 1 time
unit_moneyman.json
(3.34 KiB) Downloaded 1 time
unit_assasin.json
(3.22 KiB) Downloaded 1 time
unit_centurion.json
(3.35 KiB) Not downloaded yet
unit_hoplite.json
(3.46 KiB) Not downloaded yet
unit_roman_legionare.json
(3.61 KiB) Not downloaded yet
unit_catapult.json
(4.94 KiB) Not downloaded yet
unit_heavy_catapult.json
(4.95 KiB) Not downloaded yet

User avatar
Endru1241
Posts: 304
Joined: Fri Sep 11, 2015 8:43 am
Location: Poland

Re: JSONs for old units

Post by Endru1241 » Tue Sep 03, 2019 8:24 pm

Plus new ones.
Attachments
unit_high_priest.json
(3.78 KiB) Not downloaded yet
unit_priest.json
(3.66 KiB) Not downloaded yet
unit_fregatt.json
(3.3 KiB) Not downloaded yet
unit_adv_fregatt.json
(3.39 KiB) Not downloaded yet
unit_missionary.json
(3.66 KiB) Not downloaded yet

Stratego (dev)
Site Admin
Posts: 9402
Joined: Fri Apr 25, 2014 9:28 pm

Re: JSONs for old units

Post by Stratego (dev) » Tue Sep 03, 2019 9:07 pm

also came to me that it would be easier if u set up modding on your device so you will be able to check your json in work - would u try?

User avatar
Endru1241
Posts: 304
Joined: Fri Sep 11, 2015 8:43 am
Location: Poland

Re: JSONs for old units

Post by Endru1241 » Tue Sep 03, 2019 10:05 pm

Endru1241 wrote:
Tue Sep 03, 2019 8:23 pm
I can try.
So how to start?

User avatar
Endru1241
Posts: 304
Joined: Fri Sep 11, 2015 8:43 am
Location: Poland

Re: JSONs for old units

Post by Endru1241 » Wed Sep 04, 2019 7:35 pm

few corrections:
Attachments
unit_catapult.json
(4.94 KiB) Downloaded 1 time
unit_heavy_catapult.json
(4.95 KiB) Downloaded 1 time
unit_missionary.json
(3.67 KiB) Downloaded 1 time

Stratego (dev)
Site Admin
Posts: 9402
Joined: Fri Apr 25, 2014 9:28 pm

Re: JSONs for old units

Post by Stratego (dev) » Thu Sep 05, 2019 8:51 am

all of these are in ! thanks!

Post Reply

Return to “Dev asks for Help”